Skip to content

build: Update bom to oldest included version #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2022

Conversation

NotMyFault
Copy link
Member

(Possible) prerequisite for #2093 and newer changes, while retaining compatibility with the oldest bom profile.

Alternatively, integration tests could use a newer bom, but 2.289.x is a pretty conservative baseline.

@NotMyFault NotMyFault requested a review from a team as a code owner August 10, 2022 11:23
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Aug 10, 2022
@timja timja enabled auto-merge (squash) August 10, 2022 12:15
@NotMyFault
Copy link
Member Author

NotMyFault commented Aug 10, 2022

Javadoc errors have been fixed.

I don't know much about JCasC, but looking on the test results, it appears that JenkinsConfiguratorTest#shouldExportLabelAtoms()'s ExpectedLabelsConfiguration.yml expects something different than the test actually returns 🤔

@jetersen
Copy link
Member

@NotMyFault I believe Jenkins core introduced new default labels?

@NotMyFault
Copy link
Member Author

@NotMyFault I believe Jenkins core introduced new default labels?

Possibly? I'm not much familiar with all older changes from past year 👀

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #2095 (5542c3d) into master (079e571) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2095   +/-   ##
=========================================
  Coverage     81.01%   81.01%           
  Complexity      844      844           
=========================================
  Files            72       72           
  Lines          2507     2507           
  Branches        353      353           
=========================================
  Hits           2031     2031           
  Misses          365      365           
  Partials        111      111           
Impacted Files Coverage Δ
.../io/jenkins/plugins/casc/SecretSourceResolver.java 100.00% <ø> (ø)
.../plugins/casc/impl/secrets/DockerSecretSource.java 66.66% <ø> (ø)

@timja timja merged commit cb5ef55 into jenkinsci:master Aug 10, 2022
@NotMyFault NotMyFault deleted the build/master/bom branch August 10, 2022 14:44
@NotMyFault
Copy link
Member Author

Btw, why do builds run on GH actions and on ci.j?

@jetersen
Copy link
Member

jetersen commented Aug 10, 2022

GH actions usually is faster and easier to navigate then ci.j. Also when ci.j has issues GH actions rarely has.

@jetersen
Copy link
Member

#2097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a PR that adds to maintenance - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants