chore: use TOML config with buildx to avoid DockerHub rate limits #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherveCB
changed the title
dduportal
requested changes
Mar 25, 2025
This comment was marked as resolved.
This comment was marked as resolved.
6 tasks
lemeurherveCB
force-pushed
the
helpdesk4585-use-toml-config-with-buildx-to-avoid-docker-rate-limit
branch
from
4a49ff1 to
a290a2a
Compare
Extracted in #2003 🙂 |
lemeurherveCB
force-pushed
the
helpdesk4585-use-toml-config-with-buildx-to-avoid-docker-rate-limit
branch
from
a290a2a to
6acbf56
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks good! Can you fix the conflicts though? |
…o-avoid-docker-rate-limit
Done. |
dduportal
reviewed
Mar 26, 2025
Co-authored-by: Damien Duportal <[email protected]>
dduportal
approved these changes
Mar 26, 2025
|
LGTM! Many thanks! |
lemeurherveCB
deleted the
helpdesk4585-use-toml-config-with-buildx-to-avoid-docker-rate-limit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses TOM config with buildx if executed on CI and if
/etc/buildkitd.tomlfile exists to use registry mirrors.Pipeline reformated as there were a mix of tabs and spaces rendering the indentation less readable.(Review with whitespace hidden: https://github.com/jenkinsci/docker/pull/2002/files?diff=unified&w=1)(Extracted in #2003)
Similar to:
Ref:
docker-containerjenkins-infra/helpdesk#4585 (comment)Testing done
make docker-init+ CISubmitter checklist