[JENKINS-75533] Remove jbcrypt mindrot, use Spring Security instead

[daniel-beck]

See JENKINS-75533.

During development of this change, Spring Security added the backward compatibility I considered here, but without exposing the potential problem to users. I considered doing that for Jenkins, but there's no great way built-in to expose that information to users and ask them to change the password. I can do that if required, basically all of the code is written but I think unnecessary.

As a side effect of moving the validation into the PasswordHashEncoder this would address JENKINS-74918 as well, as demonstrated by the necessary test changes (password is shorter than 14 chars).

Depends on jenkinsci/active-directory-plugin#241 which would break.

Testing done

Screenshots

Regular

FIPS-140

Proposed changelog entries

• Improvement: Jenkins' own user database no longer accepts new passwords longer than supported by bcrypt (72 bytes). Users with longer passwords are advised to change their password.
• Internal: Switch jbcrypt implementation used for Jenkins' own user database from jbcrypt to Spring Security.
• Remove jbcrypt library. If you're using Active Directory plugin, make sure to update to version 2.40 at the same time as updating Jenkins.
• Developer: Remove org.connectbot:jbcrypt library from core BOM.

Proposed changelog category

/label developer,dependencies,internal,rfe,removed

Proposed upgrade guidelines

Unless operating in FIPS-140 mode, Jenkins' own user database no longer supports creating passwords longer than 72 bytes (UTF-8), which is the maximum length supported by the bcrypt password hashing function it uses. This length corresponds to 72 basic ASCII characters, 24-36 CJK characters, or 18 emoji 🤠.

Existing passwords longer than 72 bytes can still be used to log in.

Users with longer passwords are advised to change their password to be at most 72 bytes (and, e.g., choose from a larger character set to achieve the same complexity).

Submitter checklist

• The Jira issue, if it exists, is well-described.
• The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
• There is automated testing or an explanation as to why this change has no tests.
• New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
• New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
• New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
• For dependency updates, there are links to external changelogs and, if possible, full differentials.
• For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

• There are at least two (2) approvals for the pull request and no outstanding requests for change.
• Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
• Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
• Proper changelog labels are set so that the changelog can be generated automatically.
• If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
• If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[jtnord]

LGTM, but one comment should be updated.

[basil]

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process. Thanks!

[timja]

This is an example of a developer error message and not a user message.

For a user I would suggest something more like:

• Option 1

Jenkins’ own user database only supports passwords up to 72 characters

• Option 2

Maximum password length is 72 characters

• Option 3

Password is too long

If you really want to tweak for UTF-8 or emoji you could put a more specific error message in there only when one of these is detected.

[daniel-beck]

Thanks for the feedback. I acknowledge the problem in the Jira issue when I wrote

longer than 72 bytes (UTF-8, so good luck explaining this requirement to users)

but I couldn't think of a great alternative, other than providing examples what this means (and why "72 characters" isn't it -- option 1 and 2 are simply wrong).

Something more vague like the following might work, as it captures the important parts while being overall less technical.

usually 72 characters, fewer when using other characters, like Chinese characters or emoji

I like

put a more specific error message in there only when one of these is detected.

though, will take a stab at it.

[daniel-beck]

#10626