Skip to content

Move from RootAction to View Action #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janfaracik
Copy link

@janfaracik janfaracik commented May 22, 2025

This PR changes the Purge build queue from being a root action to being a view action instead. Root actions have been moved to the header as of jenkinsci/jenkins#10245, and in that move the ability to have custom action.jelly files has been removed - this is in an effort to enforce consistency between root actions.

As a result, this plugin got broken. This PR aims to resolve that by moving the action from a RootAction to a plain ol' Action - so it'll still appear on views as expected, but it won't appear in the header.

Requires jenkinsci/jenkins#10676 to show the view action with the new header.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant