Skip to content

react: ignore unused import removal if the import is used in needles. #29048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

mshima
Copy link
Member

@mshima mshima commented Mar 25, 2025

Some imports are required only by entity needles and are removed by eslint at generation.
Currently those imports need to be manually added otherwise the file will be broken.

This PR:

  • adjust eslint config to parse inline config but don’t report/remove them.
  • add ignore eslint rule to the lines that should not be removed.
  • add hasNonBuiltInEntity property to application so ignored lines can be optionally written.

Alternative fix for #28855.

Fixes #28855.
Closes #28866.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review March 25, 2025 16:30
@DanielFran DanielFran merged commit 2dd8c6e into jhipster:main Mar 25, 2025
61 checks passed
@mshima mshima mentioned this pull request Mar 27, 2025
6 tasks
@mraible mraible added this to the 8.10.0 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants