Skip to content

chore: update eslint-plugin-import-x #29088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 29, 2025
Merged

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 29, 2025

Related un-ts/eslint-plugin-import-x#266

cc @mshima


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@github-actions github-actions bot added the theme: dependencies Pull requests that update a dependency file label Mar 29, 2025
@JounQin JounQin changed the title fix: try import-x/resolver-next chore: try import-x/resolver-next Mar 29, 2025
@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

Why ubuntu-20.04 is used instead of ubuntu-latest?

@mshima
Copy link
Member

mshima commented Mar 29, 2025

Thanks @JounQin.
The issue is happening here:

...imports.flatConfigs.recommended.plugins,

We apply selected rules that have auto fix to generated code.

Eslint logic is here:
https://github.com/jhipster/generator-jhipster/blob/fa9eb9b71c502d0710a10eb172cdd394b84d34f5/generators/bootstrap/support/eslint-worker.js

@mshima
Copy link
Member

mshima commented Mar 29, 2025

@JounQin I've picked the config change here #29089.
I hope that's ok.

@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

@JounQin I've picked the config change here #29089. I hope that's ok.

Not sure to understand the downgrade commit.

@mshima
Copy link
Member

mshima commented Mar 29, 2025

The segmentation fault happens on the thread teardown (piscina pool destroy):

@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

Why ubuntu-20.04 is used instead of ubuntu-latest?

I think it could be related?

@mshima
Copy link
Member

mshima commented Mar 29, 2025

Why ubuntu-20.04 is used instead of ubuntu-latest?

I think it could be related?

No, #29070

@mshima
Copy link
Member

mshima commented Mar 29, 2025

@JounQin I've picked the config change here #29089. I hope that's ok.

Not sure to understand the downgrade commit.

New version doesn’t pass CI.

@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

@mshima By the way, why eslint-plugin-import-x is in dependencies, eslint-import-resolver-typescript and other eslint plugins are in devDependencies?

@mshima
Copy link
Member

mshima commented Mar 29, 2025

@mshima By the way, why eslint-plugin-import-x is in dependencies, eslint-import-resolver-typescript and other eslint plugins are in devDependencies?

eslint-plugin-import-x is applied to projects generated by JHipster at generation time.
Some rules only.

@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

@mshima I just upgraded unrs-resolver by removing --strip flag, can you help to rerun the workflows?

@JounQin
Copy link
Contributor Author

JounQin commented Mar 29, 2025

@mshima Wow, seems passing...

@mshima mshima changed the title chore: try import-x/resolver-next chore: update eslint-plugin-import-x Mar 29, 2025
@mshima mshima merged commit 8fc23fc into jhipster:main Mar 29, 2025
64 checks passed
@JounQin JounQin deleted the fix/import_x branch March 29, 2025 20:35
@mshima
Copy link
Member

mshima commented Mar 29, 2025

@JounQin thanks for your help.

@mraible mraible added this to the 8.10.0 milestone Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: CI builds theme: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants