improve presets configuration #12007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
renanfranca
commented
Feb 28, 2025
renanfranca
commented
- Fix Improve Presets configuration #11877
renanfranca
force-pushed
the
11877-improve-presets-configuration
branch
from
b7a2bb2 to
35f6c2b
Compare
renanfranca
force-pushed
the
11877-improve-presets-configuration
branch
2 times, most recently
from
25a9a0b to
d0372e6
Compare
|
@pascalgrimaud and @murdos : I recorded a demo video showing the preset improvements in action 😃 preset_improvements_demo.mp4 |
|
Sorry for taking too much time to review this one |
…ately after their usage.
… in alphabetical order
…its value directly
renanfranca
force-pushed
the
11877-improve-presets-configuration
branch
from
d0372e6 to
6b18a16
Compare
@pascalgrimaud : don't worry, I am glad that you are going to review it :). I think that is a really nice improvement, and I liked the way I coded the solution. I am looking forward to what you think ;) the rebase was done :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.