Move sse app to http #358
Merged
Move sse app to http #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the SSE handling by moving its instantiation to the HTTP module, simplifying the server’s responsibility.
- Removed old SSE app implementation and its related middleware imports from server.py
- Introduced a new create_sse_app in http.py to configure and return the SSE Starlette application
- Renamed internal route accumulation variable to better reflect its purpose
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fastmcp/server/server.py | Refactored SSE app creation and renamed _custom_starlette_routes to _additional_http_routes to align with HTTP usage |
| src/fastmcp/server/http.py | Added create_sse_app to encapsulate SSE configuration and routing with auth, consolidating previous SSE logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor in preparation for streamble http