Deprecate transport-specific methods on FastMCP server #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates multiple transport‐specific methods on the FastMCP server and introduces a unified API via run_http_async() and http_app() with a transport keyword to select the desired behavior. Key changes include updated tests to use the new API, server-side refactoring of async run methods with deprecation wrappers, and corresponding documentation updates.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/* | Update tests to use http_app() and run_http_async() |
| src/fastmcp/server/server.py | Refactor run_async methods; add run_http_async(); deprecate run_sse_async/run_streamable_http_async |
| docs/* | Adjust deprecation notices, usage examples, and transport descriptions |
jlowin
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
run_http_async()andhttp_app()methods to the FastMCP instance, with atransportkwarg, and adds related deprecation notices torun_sse_async(),run_streamable_http_async(),sse_app(), andstreamable_http_app()(which still function).Related to discussion in #396