doc(asgi): Change custom route example to PlainTextResponse #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the doc examples of custom routes to use
PlainTextResponse
instead ofJSONResponse
Why
streamable_http
expects the client to connect with a header fortext/event-stream
- so if you actually use the old example, you'll fail when trying to return JSON from Starlette/FastAPI with this error message:which makes it seem like a client issue, but it's actually just the response body not being plain text.