Remove customizable separators; improve resource separator #526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change because it removes user-customizable separators when mounting servers under a prefix. However, these customizable prefixes caused a problem for resources in particular because the resource prefix became part of the URI protocol, which has even more restrictions than other parts of the URI (like the path). For example, if you mounted a server with the prefix
"sub_server"
it would fail because protocols can't have underscores.This PR modifies resource prefixes to become part of the path not the protocol. In other words,
protocol://path/to/resource
becomesprotocol://prefix/path/to/resource
in the new setup, which is far more natural. On the plus side this improves our support for arbitrary prefix mounts.As an extension, customziable separators are no longer supported and will give a deprecation warning.