[5.3][cypress] do not ignore all uncaught:exception #44718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
joomla-cms-bot
added
the
NPM Resource Changed
joomla-cms-bot
removed
the
NPM Resource Changed
heelc29
force-pushed
the
5.2/cypress/js-exception
branch
from
6d9e0f6 to
d7fd00f
Compare
heelc29
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
At the moment all js errors do not lead to a direct failure of the system tests
So for example this #44553 error could be detected and fixed before a release
Testing Instructions
manipulate js code the get an exception and run a test which load this js file
Actual result BEFORE applying this Pull Request
test not failing
Expected result AFTER applying this Pull Request
test failing
Link to documentations
Please select: