[5.3] RTL Calendar Days #44900

brianteeman · 2025-02-14T12:40:02Z

When the calendar is being displayed with an RTL language the data in the calendar is correctly ordered RTL. However the names od the days is incorrect as this remains LTR

This PR adds a conditional check for RTL and reverses the string of days so that it is displayed correctly

Note that JS is not my thing and it looks like there is code for this already at line 140 but it is not working? Maybe a js expert can see why.

Pull Request for Issue #44818 .

Testing Instructions

Install an RTL language which uses the gregorian calendar OR edit administrator\language\en-GB\langmetadata.xml and set rtl to 1

as this is a js change you will need to apply the pr and then npm run build:js or use a prebuilt package

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

When the calendar is being displayed with an RTL language the data in the calendar is correctly ordered RTL. However the names od the days is incorrect as this remains LTR This PR adds a conditional check for RTL and reverses the string of days so that it is displayed correctly Note that JS is not my thing and it looks like there is code for this already at line 140 but it is not working? Maybe a js expert can see why. Signed-off-by: BrianTeeman <[email protected]>

fgsw · 2025-02-14T13:13:25Z

Prebuilt packages are not available for download, also not the custom update server:

richard67 · 2025-02-14T13:31:00Z

Prebuilt packages are not available for download, also not the custom update server:

Seems there is an issue with a full disk. Will notify some people.

fgsw · 2025-02-15T05:16:17Z

Later created Pull Request have now available Prebuilt packages (this one still not).

richard67 · 2025-02-15T09:39:58Z

I‘ve restarted the drone build, so new packages should be available soon.

richard67 · 2025-02-15T09:44:55Z

Packages are available now.

richard67 · 2025-02-15T10:58:56Z

Normally I would say this PR is a bug fix so it has to go into 5.2-dev ... but as it comes too late for 5.2.4 it would go into 5.2.5, which will be released just 2 weeks before 5.3.0 stable, so I think it doesn't really matter.

fgsw · 2025-02-15T11:13:45Z

I have tested this item ✅ successfully on 0c4cb29

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44900.}

richard67 · 2025-02-15T11:56:04Z

Install an RTL language which uses the gregorian calendar

@brianteeman I've tested with Urdu, which uses Gregorian calendar, and to see that nothing is broken I've tested also with Persian (Farsi), which uses the Jalali calendar. In both cases the day order changes with your PR. As I don't speak or read Farsi or Urdu I have to investigate if your PR is right. But maybe your testing instruction only forgot to mention Jalali calendar?

richard67 · 2025-02-15T12:20:53Z

For Urdu (Pakistan) ur-PK, which uses the Gregorian calendar, the PR works as described, i.e. only the direction of weekday headings has changed:

For Farsi (Persian, Iran) fa-IR, which uses the Jalali calendar, the PR not only changes the direction but also the week start:

As I don't understand Farsi, I can't say right now which one is right.

richard67 · 2025-02-15T12:31:43Z

~~Possibly the code added by this PR should not be added after but before line 654?~~
No, forget it.

richard67 · 2025-02-15T12:59:40Z

I've found https://www.parstimes.com/persian/calendar/ , but the day names or abbreviations in the calendar for today look completely different to me:

richard67 · 2025-02-15T14:22:31Z

I've emailed the Persian translation coordinator. I did not get an answer yet, but right now it looks as if this PR fixes the issue also for Persian, i.e. the PR is right. At least that's the feedback I got up to now from discussion in Mattermost.

If that is confirmed, this PR will get a successful test from me.

brianteeman · 2025-02-17T09:58:49Z

I would still like a js person to review this especially because of

Note that JS is not my thing and it looks like there is code for this already at line 140 but it is not working? Maybe a js expert can see why.

brianteeman · 2025-04-25T21:05:22Z

I've emailed the Persian translation coordinator. I did not get an answer yet, but right now it looks as if this PR fixes the issue also for Persian, i.e. the PR is right. At least that's the feedback I got up to now from discussion in Mattermost.

If that is confirmed, this PR will get a successful test from me.

am i wasting my time here

richard67 · 2025-04-26T08:59:01Z

I've emailed the Persian translation coordinator. I did not get an answer yet, but right now it looks as if this PR fixes the issue also for Persian, i.e. the PR is right. At least that's the feedback I got up to now from discussion in Mattermost.
If that is confirmed, this PR will get a successful test from me.

am i wasting my time here

@brianteeman No, just leave the PR open. I did not get a reply from them. I will try again and try to find other testers. Give me a bit time. I'm optimistic we can get this ready for 5.3.x, if not 5.3.1 then 5.3.2.

Update: I just see it has already 1 good test (which I've restored after branch update because still valid).

richard67 · 2025-04-26T11:09:33Z

Ok, I have found out what the issue with the Persian calendar is:

The translators have worked around the issue in their joomla.ini file.

Currently that is:

; Days of the Week
SAT="ی"
SATURDAY="یکشنبه"
SUN="ش"
SUNDAY="شنبه"
MON="ج"
MONDAY="جمعه"
TUE="پ"
TUESDAY="پنجشنبه"
WED="چ"
WEDNESDAY="چهارشنبه"
THU="س"
THURSDAY="سه شنبه"
FRI="د"
FRIDAY="دوشنبه"

When throwing that into a translator or check at https://en.wikipedia.org/wiki/Names_of_the_days_of_the_week you will see that they have used for Sunday the translation of Saturday, for Monday the translation of Friday, for Tuesday the translation of Thursday, Wednesday ir right, for Thursday they have used the translation of Tuesday, for Friday the translation of Monday and for Saturday the one of Sunday.

That means they have worked around the reverse order and also the wrong start of the week and weekend days in their langmetadata.xml.

Or in short words: This PR here is right (as my test for Urdu ur-PK has shown), but it will need a fix in their translations when this PR gets merged and released because it breaks their ugly workaround.

@tecpromotion Do you have a contact to the Persian translators? I had tried the email address from the translation downloads but did not get any answer when I had asked for their advice before.

richard67 · 2025-04-26T11:17:05Z

I have tested this item ✅ successfully on 7319a4b

I've successfully tested with Urdu (ur-PK) and with German (de-DE), the latter patched to RTL in the langmetadata.xml.

The different week start day (Monday in de-DE, Sunday in the others) was also correctly handled.

The issues I've discovered for the Persian calendar are caused by a wrong workaround in their translation, see my previous comment.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44900.}

richard67 · 2025-04-26T11:17:20Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44900.}

richard67 · 2025-04-26T12:03:45Z

In the Persian (fa-IR) langmetadata.xml, the <weekEnd>0,6</weekEnd> should be changed to <weekEnd>5</weekEnd> because due to their current law only Friday is weekend. The <firstDay>6</firstDay> is correct, their working week starts on Saturday.

In the Persian (fa-IR) joomla.ini file, the week days should be changed
from

; Days of the Week
SAT="ی"
SATURDAY="یکشنبه"
SUN="ش"
SUNDAY="شنبه"
MON="ج"
MONDAY="جمعه"
TUE="پ"
TUESDAY="پنجشنبه"
WED="چ"
WEDNESDAY="چهارشنبه"
THU="س"
THURSDAY="سه شنبه"
FRI="د"
FRIDAY="دوشنبه"

to

; Days of the Week
SAT="ش"
SATURDAY="شنبه"
SUN="ی"
SUNDAY="یکشنبه"
MON="د"
MONDAY="دوشنبه"
TUE="س"
TUESDAY="سه شنبه"
WED="چ"
WEDNESDAY="چهارشنبه"
THU="پ"
THURSDAY="پنجشنبه"
FRI="ج"
FRIDAY="جمعه"

rdeutz · 2025-05-14T09:39:51Z

@dgrammatiko could you have a look here?

Note that JS is not my thing and it looks like there is code for this already at line 140 but it is not working? Maybe a js expert can see why.

bembelimen · 2025-05-19T08:23:57Z

Thx

brianteeman · 2025-05-19T08:47:12Z

thanks

joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 14, 2025

brianteeman mentioned this pull request Feb 14, 2025

RTL Calendar Days #44818

Closed

richard67 added the bug label Feb 14, 2025

Merge branch '5.3-dev' into rtl_calendar

7319a4b

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 26, 2025

bembelimen merged commit c26b622 into joomla:5.3-dev May 19, 2025
4 checks passed

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 19, 2025

bembelimen added this to the Joomla! 5.3.1 milestone May 19, 2025

brianteeman deleted the rtl_calendar branch May 19, 2025 08:47

Uh oh!

[5.3] RTL Calendar Days #44900

[5.3] RTL Calendar Days #44900

Uh oh!

Conversation

brianteeman commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Uh oh!

fgsw commented Feb 14, 2025

Uh oh!

richard67 commented Feb 14, 2025

Uh oh!

fgsw commented Feb 15, 2025

Uh oh!

richard67 commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Feb 15, 2025

Uh oh!

richard67 commented Feb 15, 2025

Uh oh!

fgsw commented Feb 15, 2025

Uh oh!

richard67 commented Feb 15, 2025

Uh oh!

richard67 commented Feb 15, 2025

Uh oh!

richard67 commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Feb 15, 2025

Uh oh!

richard67 commented Feb 15, 2025

Uh oh!

brianteeman commented Feb 17, 2025

Uh oh!

brianteeman commented Apr 25, 2025

Uh oh!

richard67 commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Apr 26, 2025

Uh oh!

richard67 commented Apr 26, 2025

Uh oh!

richard67 commented Apr 26, 2025

Uh oh!

richard67 commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rdeutz commented May 14, 2025

Uh oh!

Uh oh!

bembelimen commented May 19, 2025

Uh oh!

brianteeman commented May 19, 2025

Uh oh!

Uh oh!

brianteeman commented Feb 14, 2025 •

edited

Loading

richard67 commented Feb 15, 2025 •

edited

Loading

richard67 commented Feb 15, 2025 •

edited

Loading

richard67 commented Apr 26, 2025 •

edited

Loading

richard67 commented Apr 26, 2025 •

edited

Loading