-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Change the media manager from CMSObject to stdClass #44945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have tested this item 🔴 unsuccessfully on 51644be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945. |
Are you on Joomla 6? Because the file /administrator/components/com_media/helpers/media.php should accept \stdClass and not CMSObject |
I have tested this item ✅ successfully on 06c6e04 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945. |
Warning after deleting a file:
|
See #44989 |
I have tested this item ✅ successfully on 06c6e04 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44945. |
This is a hard b/c break, in the discussion yesterday we came up with a solution use the compact plugin. |
Discused this today in the maintainer chat and there is no reliable and easy to maintain solution to this issue. So this change is absolute ok. |
Thanks @laoneo and testers |
Thanks and don't forget the docu |
here is your solution #45216 |
Summary of Changes
Change the object in the media manager for the events from object to stdClass.
Testing Instructions
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Change the media manager from CMSObject to stdClass Manual#395
No documentation changes for manual.joomla.org needed