Skip to content

[5.3][webservices] Undefined property: stdClass::$modified_by #45043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Mar 1, 2025

Pull Request for Issue #44947 .

Summary of Changes

define $modified_by

Testing Instructions

Do an API GETcall to

  • /api/index.php/v1/newsfeeds/feeds
  • /api/index.php/v1/contacts

See PHP error log.

Actual result BEFORE applying this Pull Request

Undefined property: stdClass::$modified_by in \api\components\com_newsfeeds\src\Serializer\NewsfeedSerializer.php on line 110
Undefined property: stdClass::$modified_by in \api\components\com_newsfeeds\src\Serializer\NewsfeedSerializer.php on line 111
Undefined property: stdClass::$modified_by in \api\components\com_contact\src\Serializer\ContactSerializer.php on line 110
Undefined property: stdClass::$modified_by in \api\components\com_contact\src\Serializer\ContactSerializer.php on line 111

Expected result AFTER applying this Pull Request

no more

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review March 1, 2025 08:40
@muhme
Copy link
Contributor

muhme commented Mar 1, 2025

✅ successful tested with JBT, before applying this PR

scripts/create 53
scripts/test 53 system api/com_newsfeed/NewsFeed.cy.js

There are PHP Warnings:

[Sat Mar 01 15:40:30.671730 2025] [php:warn] [pid 73:tid 73] [client 10.0.0.1:60956] PHP Warning:  Undefined property: stdClass::$modified_by in /var/www/html/api/components/com_newsfeeds/src/Serializer/NewsfeedSerializer.php on line 110
[Sat Mar 01 15:40:30.671786 2025] [php:warn] [pid 73:tid 73] [client 10.0.0.1:60956] PHP Warning:  Undefined property: stdClass::$modified_by in /var/www/html/api/components/com_newsfeeds/src/Serializer/NewsfeedSerializer.php on line 111

Applying this PR and run test again:

scripts/patch 53 joomla-cms-45043
scripts/test 53 system api/com_newsfeed/NewsFeed.cy.js

The Cypress test runs now without PHP Warnings successfully 👍

@QuyTon
Copy link
Contributor

QuyTon commented Mar 2, 2025

I have tested this item ✅ successfully on d7cd31c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45043.

@QuyTon
Copy link
Contributor

QuyTon commented Mar 2, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45043.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 2, 2025
@laoneo laoneo merged commit 8202206 into joomla:5.3-dev Mar 5, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 5, 2025
@laoneo
Copy link
Member

laoneo commented Mar 5, 2025

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants