Skip to content

[5.3] Fix warnings on frontend template options editing #45053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue #45050.

Summary of Changes

This PR fixes warnings on frontend template options editing page. See #45050 for details issue description.

Testing Instructions

  1. Use latest Joomla 5.3
  2. Create a menu item to link to Display Template Options menu item type
  3. Login to frontend of your site using a super user account
  4. Access to above menu item

Actual result BEFORE applying this Pull Request

You see warning: Warning: SimpleXMLElement::xpath(): Unfinished literal in \libraries\src\Form\Form.php on line 1259

Expected result AFTER applying this Pull Request

No warnings anymore

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Mar 2, 2025

I have tested this item ✅ successfully on 3cdcb69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45053.

@cyrez
Copy link
Contributor

cyrez commented Mar 3, 2025

I have tested this item ✅ successfully on 3cdcb69

Turned on error reporting first.

Works as expected, warning removed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45053.

@QuyTon
Copy link
Contributor

QuyTon commented Mar 3, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45053.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 3, 2025
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Mar 8, 2025
@laoneo laoneo merged commit 75e8161 into joomla:5.3-dev Mar 9, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 9, 2025
@laoneo
Copy link
Member

laoneo commented Mar 9, 2025

Thanks!

@joomdonation joomdonation deleted the fix_warning_template_options_edit branch March 9, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants