Skip to content

[5.3] Allow email addresses with an underscore #45102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2025

Conversation

charvimehradu
Copy link
Contributor

@charvimehradu charvimehradu commented Mar 9, 2025

Pull Request for Issue #45100 .

Summary of Changes

Modify the $searchEmail pattern by adding the underscore character to the character class where it's currently matching letters, numbers, and special characters like periods, apostrophes, hyphens, and plus signs.

Testing Instructions

  • Navigate to System > Plugins > Content-Email Cloaking.
  • Confirm that Email Obfuscation (Email cloaking) is enabled.
  • Test it by entering email addresses with underscores (e.g., [email protected]).

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ChristineWk
Copy link

Testing Instructions:

The 1st point should be: Plugins > Content-Email Cloaking


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 74ec6b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102.

@BennoMath
Copy link

BennoMath commented Mar 9, 2025

I have tested this item ✅ successfully on 74ec6b1
Before patch:
email-cloaking_before-patch

After patch:
email-cloaking_after-patch

@dautrich
Copy link

dautrich commented Mar 9, 2025

I have tested this item ✅ successfully on 74ec6b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102.

@chmst
Copy link
Contributor

chmst commented Mar 9, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2025
@richard67
Copy link
Member

richard67 commented Mar 9, 2025

@ChristineWk @BennoMath @dautrich Have you also tested that an email address without underscore still works?

Am asking because that part is missing in the testing instructions. But it should always be tested that nothing is broken by a fix, not only that the issue is fixed.

This just in general, I don’t expect any issues.

@ChristineWk
Copy link

@ChristineWk @BennoMath @dautrich Have you also tested that an email address without underscore still works?

Am asking because that part is missing in the testing instructions. But it should always be tested hat nothing is broken by a fix, not only that the issue is fixed.

This just in general, I don’t expect any issues.

I just checked it with activated PR. It's OK.

@richard67
Copy link
Member

I just checked it with activated PR. It's OK.

@ChristineWk Thanks for checking. That’s sufficient for me.

@charvimehradu
Copy link
Contributor Author

Thank you everyone for testing this PR.

@dautrich
Copy link

@richard67 I also successfully checked with an email address without an underscore, with the PR code applied.

@BennoMath
Copy link

@richard67 Yes, successfully tested also with an email address without underscore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45102.

@richard67 richard67 changed the base branch from 5.2-dev to 5.3-dev March 14, 2025 13:00
@richard67 richard67 changed the title Allow email addresses with an underscore [5.3] Allow email addresses with an underscore Mar 14, 2025
@richard67 richard67 added the bug label Mar 14, 2025
@richard67 richard67 enabled auto-merge (squash) March 14, 2025 13:36
@richard67 richard67 added this to the Joomla! 5.3.0 milestone Mar 14, 2025
@richard67 richard67 merged commit bf5bfe4 into joomla:5.3-dev Mar 14, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 14, 2025
@richard67
Copy link
Member

Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants