Skip to content

[5.3] Installer rtl logical css #45420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 12, 2025

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented May 1, 2025

At some point in time a change was made and the post scss rtlcss started processing the installation template scss files so it was actually reversing everything - doh - so any directives in the current rtl-scss were being reverted by rtlcss

Summary of Changes

Made sure the installation template uses logical css properties (-start, -end instead of -left, -right)
Fixed the css generation so that the rtlcss now works as intended - thanks @dgrammatiko
Removed all overrides from template-rtl,scss as they are not needed with logical css and a working rtlcss processing

Testing Instructions

Apply pr and npm run build:css or use a pre-built package
Check everything "looks" ok in both LTR and RTL languages

Actual result BEFORE applying this Pull Request

before

Expected result AFTER applying this Pull Request

after

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels May 1, 2025
@brianteeman brianteeman marked this pull request as ready for review May 1, 2025 21:13
@brianteeman brianteeman changed the title DRAFT Installer rtl logical css [5.2] Installer rtl logical css May 1, 2025
@brianteeman brianteeman changed the title [5.2] Installer rtl logical css [5.3] Installer rtl logical css May 1, 2025
@dgrammatiko
Copy link
Contributor

@brianteeman please remove these lines, (belong to another PR)

const silenceDeprecationList = [


   `media_source${sep}templates`,
   `installation${sep}template`,
   `media_source${sep}plg_installer_webinstaller`,
   `vendor${sep}fontawesome-free`,
   `media_source${sep}system${sep}scss${sep}joomla-fontawesome.scss`,
   `media_source${sep}com_media`,
   `media_source${sep}plg_system_guidedtours${sep}scss${sep}guidedtours.scss`,
 ];
 const shouldSilenceDeprecation = (file) => silenceDeprecationList.some((path) => new RegExp(String.raw`${path}`, 'i').test(file));
  const options = shouldSilenceDeprecation(file) ? { silenceDeprecations: ['mixed-decls', 'color-functions', 'import', 'global-builtin'] } : {};

and change const { css } = await compileAsync(file, options); to const { css } = await compileAsync(file);

Signed-off-by: BrianTeeman <[email protected]>
@brianteeman
Copy link
Contributor Author

@brianteeman please remove these lines, (belong to another PR)

done

@QuyTon
Copy link
Contributor

QuyTon commented May 3, 2025

I have tested this item ✅ successfully on 151e865


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420.

1 similar comment
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 151e865


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420.

@alikon
Copy link
Contributor

alikon commented May 7, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 7, 2025
@brianteeman
Copy link
Contributor Author

I would appreciate it if this could be merged as I have several PR waiting the changes to the RTL tooling that are contained in this PR

@HLeithner HLeithner merged commit 758b7be into joomla:5.3-dev May 12, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 12, 2025
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the installer-rtl-logical-css branch May 12, 2025 10:41
@QuyTon QuyTon added this to the Joomla! 5.3.1 milestone May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants