-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[5.3] Installer rtl logical css #45420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Installer rtl logical css #45420
Conversation
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
@brianteeman please remove these lines, (belong to another PR) const silenceDeprecationList = [
`media_source${sep}templates`,
`installation${sep}template`,
`media_source${sep}plg_installer_webinstaller`,
`vendor${sep}fontawesome-free`,
`media_source${sep}system${sep}scss${sep}joomla-fontawesome.scss`,
`media_source${sep}com_media`,
`media_source${sep}plg_system_guidedtours${sep}scss${sep}guidedtours.scss`,
];
const shouldSilenceDeprecation = (file) => silenceDeprecationList.some((path) => new RegExp(String.raw`${path}`, 'i').test(file)); const options = shouldSilenceDeprecation(file) ? { silenceDeprecations: ['mixed-decls', 'color-functions', 'import', 'global-builtin'] } : {}; and change |
Signed-off-by: BrianTeeman <[email protected]>
done |
Co-authored-by: Quy Ton <[email protected]>
I have tested this item ✅ successfully on 151e865 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420. |
1 similar comment
I have tested this item ✅ successfully on 151e865 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45420. |
I would appreciate it if this could be merged as I have several PR waiting the changes to the RTL tooling that are contained in this PR |
thanks |
At some point in time a change was made and the post scss rtlcss started processing the installation template scss files so it was actually reversing everything - doh - so any directives in the current rtl-scss were being reverted by rtlcss
Summary of Changes
Made sure the installation template uses logical css properties (-start, -end instead of -left, -right)
Fixed the css generation so that the rtlcss now works as intended - thanks @dgrammatiko
Removed all overrides from template-rtl,scss as they are not needed with logical css and a working rtlcss processing
Testing Instructions
Apply pr and npm run build:css or use a pre-built package
Check everything "looks" ok in both LTR and RTL languages
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed