[5.4] Add tag filter none com_newsfeeds

[brianteeman]

The aim of this PR is to add a new filter option when filtering for tags that allows you to filter all newsfeeds that have no tags at all.

This is only for com_newsfeeds (articles and featured articles already done with #45274)

To test create four newsfeeds
Newsfeed 1 no tags
Newsfeed 2 taga
Newsfeed 3 3 tagb
Newsfeed 4 taga and tagb

Using the filter check that the filter works correctly when selecting any of the tags AND/OR items with no tags (None)

You should be able to filter the newsfeeds on any single tag or combination of tags AND filter the contacts with no tags and any single tag or combination of tags

Thanks to @richard67 for the query

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

@richard67 I know this was your query but I wonder if it should be changed

from
$db->quoteName('tagmap.type_alias') . ' = ' . $db->quote('com_newsfeeds.newsfeed'),

to
$db->quoteName('tagmap.type_alias') . ' = :typeAlias',

[richard67]

@brianteeman No, it's a hard-coded string and nothing from input, so no need for a bind variable here. See also where it is not modified by this PR: https://github.com/joomla/joomla-cms/pull/45460/files#diff-38c1de4d15fa0ac13f1c64c411eda1ae91777431a00ca4a6ba2a2e906f9c1138R337

[brianteeman]

I was prompted to ask the question when I saw

joomla-cms/administrator/components/com_categories/src/Model/CategoriesModel.php

Line 363 in ba5d40a

$db->quoteName('tagmap.type_alias') . ' = :typeAlias',

[brianteeman]

never mind I can see why com_categories is different

[richard67]

never mind I can see why com_categories is different

Yes, cause there the code is used for different contexts (type aliases).

[exlemor]

I have tested this item ✅ successfully on b905a3f

I have tested this successfully just like for com_contact.

Works as expected: None, TagA, TagB, TagA+TagB, None+TagA, None+TagB, None+TagA+TagB :)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45460.}

[krishnaGandhi11]

I have tested this item ✅ successfully on b905a3f

I have tested this PR, works as expected!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45460.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45460.}

[muhme]

Thank you all for your contribution.

[brianteeman]

thanks