using build num #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good idea for sure though we need to update the test. Sorry had the setting to approve before running tests that I need to turn off. |
|
I merged this change in on another branch trying to figure out why the tests are failing. It is in master but seems GitHub actions are now down so I want to wait to release. Thank you for making the change! |
|
This has been released and published |
|
Nice, thanks @jtwebman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using two build nums, not sure what else can go in the space for
service_numberbutservice_job_numbershould defo be using theCIRCLE_BUILD_NUMover theCIRCLE_WORKFLOW_ID