Fix fzf with no cmdline arguments on Cygwin #4383
Conversation
|
This PR makes fzf work in my Cygwin64 installation on Windows 10. |
| argStr := escapeSingleQuote(args[0]) | ||
| _argStr := "" | ||
|
|
||
| osname, _ := exec.Command("uname", "-s").Output() |
There was a problem hiding this comment.
So we would have to start a process to determine if we're running Cygwin, but this has a cost. Can there be a lighter way to do it, like checking if an environment variable exists?
There was a problem hiding this comment.
You have a good point. Based on their respective man pages, in bash and zsh we can check that os.Getenv("OSTYPE") == "cygwin", but fish makes no mention of OSTYPE and I don't see a better option than uname in that case. Perhaps that little complication can be ironed out by looking at opts.{Bash,Zsh,Fish}?
There was a problem hiding this comment.
Is there any environment variable that shows you're on Cygwin? Something like $CYGWIN or $CYG*?
This addresses issue #4382.
In module
src/winpty_windows.go, functionrunWinpty()is handing off the executable's full pathname torunProxy()as the first argument. The path was coming over Windows-style and causing Cygwin to choke. So I'm checkinguname -sfor Cygwin and callingcygpathto reformat if needed. Very basic test runs now looking good: