Skip to content

Add Cache API #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Add Cache API #3382

merged 1 commit into from
May 26, 2025

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Apr 17, 2025 •
edited
Loading

Summary

Add the Replication api behind a feature flag.

What Type of PR Is This?

/kind api-change
/kind feature

Related Issue(s)

Fixes #3367

Release Notes

Add Caching API under cache.kcp.io to be able to interact with cache server programmatically.

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. labels Apr 17, 2025
@kcp-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2025
@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from e467933 to 140e811 Compare April 17, 2025 18:04
@mjudeikis mjudeikis changed the title Mjudeikis/cache.api Add Cache API Apr 18, 2025
@mjudeikis
Copy link
Contributor Author

/test all

sttts
sttts reviewed Apr 23, 2025
View reviewed changes
sttts
sttts reviewed Apr 23, 2025
View reviewed changes
sttts
sttts reviewed Apr 23, 2025
View reviewed changes
sttts
sttts reviewed Apr 23, 2025
View reviewed changes
sttts
sttts reviewed Apr 23, 2025
View reviewed changes
sttts
sttts reviewed Apr 23, 2025
View reviewed changes
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2025
ntnn
ntnn suggested changes Apr 30, 2025
View reviewed changes
@kcp-ci-bot
Copy link
Contributor

@ntnn: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added the area/cli Issues or PRs related to CLI changes label May 1, 2025
@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from 7525166 to 1be5642 Compare May 1, 2025 13:58
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2025
@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from 97841c0 to bed1fa4 Compare May 1, 2025 14:48
@mjudeikis mjudeikis marked this pull request as ready for review May 1, 2025 14:48
@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels May 1, 2025
@mjudeikis
Copy link
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0cf46be4da28047fa6475c55cbd738db2da3264

@mjudeikis mjudeikis requested a review from sttts May 12, 2025 04:40
@kcp-ci-bot kcp-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from b65549e to c96d4a4 Compare May 15, 2025 14:51
@kcp-ci-bot kcp-ci-bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@kcp-ci-bot kcp-ci-bot requested a review from ntnn May 15, 2025 14:52
@kcp-ci-bot kcp-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2025
@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from c96d4a4 to baa5656 Compare May 15, 2025 15:02
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch 4 times, most recently from 2b8c1d3 to d50f567 Compare May 23, 2025 12:07
@mjudeikis
Copy link
Contributor Author

/test all

embik
embik reviewed May 26, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions and nits.

@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from d50f567 to 88fcddf Compare May 26, 2025 13:40
@mjudeikis
Add replication api
4a07406 
Signed-off-by: Mangirdas Judeikis <[email protected]>
 On-behalf-of: @SAP [email protected]
@mjudeikis mjudeikis force-pushed the mjudeikis/cache.api branch from 88fcddf to 4a07406 Compare May 26, 2025 13:49
embik
embik approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4825905ee1c17ea647b6aad50ecfe1ac0b23b931

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@kcp-ci-bot kcp-ci-bot merged commit 3037f91 into kcp-dev:main May 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gman0 gman0 gman0 left review comments

@embik embik embik approved these changes

@sttts sttts Awaiting requested review from sttts

@ntnn ntnn Awaiting requested review from ntnn

Assignees

@embik embik

@ntnn ntnn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Issues or PRs related to CLI changes dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: Implement replication API
6 participants
@mjudeikis @kcp-ci-bot @sttts @gman0 @embik @ntnn