-
Notifications
You must be signed in to change notification settings - Fork 408
docs: Particularize Initializers and Provide Sample Code #3412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Particularize Initializers and Provide Sample Code #3412
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
14d5d6b
to
fe0fc0d
Compare
On-behalf-of: SAP <[email protected]> Signed-off-by: Simon Bein <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Simon Bein <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Simon Bein <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Simon Bein <[email protected]>
fe0fc0d
to
880a48d
Compare
Regarding (1): Maybe it makes sense to focus on the code parts that are relevant to building such a controller instead of a fully working example that includes standard stuff like setting up a manager, generating a rest config, etc? Regarding (2): I'm not quite sure, but I suspect the following is happening: When you patch the But @mjudeikis should comment on this too, it's just a hunch at this point. |
/ok-to-test |
@SimonTheLeg: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Summary
Before starting with a detailed review of the content: Two open questions from my side
For now I have put the code into mkdocs tabs to directly live in the documentation. As the example is rather complex, I am thinking it would be better to place this somewhere into our repo and link from to docs to it. Do you agree? If yes, where would be the best place to put the example?
The code works and initializes the workspaces correctly. However it still logs errors like this one. Do you have any ideas what this could be? Since it logs them constantly, I am not feeling quite happy with the code, but I cannot figure out how to fix it. I have tried setting
lc.Name = req.Name
, but this runs into the same issueWhat Type of PR Is This?
/kind documentation
Related Issue(s)
Fixes: making kcp docs a better place :)
Release Notes