Skip to content

Add a flag in tracing config to use service instead of pod name #3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pomyslowynick
Copy link

@pomyslowynick pomyslowynick commented Mar 31, 2025

Add a flag in tracing config to use service instead of pod name

While the OTel migration is in progress it would be very helpful to have a flag which allows users toggling the ServingService to be used as the service.name in traces.
This is related to this issue and would still be relevant after the migration to OTel.

From my own experience, service.name is used to group the traces together and when it's set to the pod name it's impossible to keep them all together.

This flag is a noop for existing configurations, since it defaults to false and will be used in another PR
I've tested it in a live cluster for true/false/undefined values in the config map, in all the cases it worked as expected.

/kind enhancement

Release Note

You can now use the `useServingService` flag in the tracing config to use the `ServingService` as the `service.name` in traces. Current default is to use the `ServingPod` as the `service.name`, and it remains the same if the flag is not set.

Copy link

knative-prow bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pomyslowynick
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from creydr and skonto March 31, 2025 10:23
Copy link

linux-foundation-easycla bot commented Mar 31, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Mar 31, 2025

Welcome @pomyslowynick! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 31, 2025
Copy link

knative-prow bot commented Mar 31, 2025

Hi @pomyslowynick. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/hold

I want to revisit this after the next release (Apr 22) - I think for the subsequent release we should do real work to migrate to OTel. Supposedly they are removing OpenCensus support in the OTel collector.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants