-
Notifications
You must be signed in to change notification settings - Fork 334
Add a flag in tracing config to use service instead of pod name #3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pomyslowynick The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @pomyslowynick! It looks like this is your first PR to knative/pkg 🎉 |
Hi @pomyslowynick. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/hold I want to revisit this after the next release (Apr 22) - I think for the subsequent release we should do real work to migrate to OTel. Supposedly they are removing OpenCensus support in the OTel collector. |
Add a flag in tracing config to use service instead of pod name
While the OTel migration is in progress it would be very helpful to have a flag which allows users toggling the
ServingService
to be used as theservice.name
in traces.This is related to this issue and would still be relevant after the migration to OTel.
From my own experience,
service.name
is used to group the traces together and when it's set to the pod name it's impossible to keep them all together.This flag is a
noop
for existing configurations, since it defaults tofalse
and will be used in another PRI've tested it in a live cluster for true/false/undefined values in the config map, in all the cases it worked as expected.
/kind enhancement
Release Note