✨ Expose all Go runtime metrics #3070
Conversation
Signed-off-by: dongjiang <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @dongjiang1989. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
dongjiang1989
changed the title
Signed-off-by: dongjiang <[email protected]>
| @@ -89,6 +91,13 @@ func init() { | |||
| // expose process metrics like CPU, Memory, file descriptor usage etc. | |||
| collectors.NewProcessCollector(collectors.ProcessCollectorOpts{}), | |||
| // expose Go runtime metrics like GC stats, memory stats etc. | |||
| collectors.NewGoCollector(), | |||
| collectors.NewGoCollector( | |||
There was a problem hiding this comment.
I don't think we want this change - Any config we put in here will be wrong for some cases so we'd rather keep it as-is to avoid the breaking change. You can unregister and re-register these in the config you need if the default doesn't work for you: https://github.com/gitpod-io/gitpod/blob/58e1f558c90aa819b6061ce170ad7b0320183dec/components/ws-daemon/pkg/daemon/daemon.go#L63
/hold
There was a problem hiding this comment.
@dongjiang1989 Was chatting with Alvaro.
In general we don't want to finetune things like this too much as it's hard to find something that works for everyone.
But in this specific case we're good. It did some research and it turns out we can simply enable all Go metrics as there are not that many. SO it's not too much overhead. And having all Go metrics should of course work for everyone
Please change this to:
collectors.NewGoCollector(collectors.WithGoCollectorRuntimeMetrics(collectors.MetricsAll))(btw component-base, i.e. kube-apiserver, ... are doing the same)
/hold cancel
There was a problem hiding this comment.
Thanks @alvaroaleman and @sbueringer
Changed it
Add all Go runtime metrics
k8s-ci-robot
added
do-not-merge/hold
Signed-off-by: dongjiang <[email protected]>
k8s-ci-robot
added
size/XS
sbueringer
added
the
tide/merge-method-squash
|
Thx! /ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1206305a1a82d908a9103b0cb3f48bc529a65eba
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, dongjiang1989 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-0.20 |
|
/cherry-pick release-0.19 |
|
@sbueringer: new pull request created: #3100 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sbueringer: new pull request created: #3101 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
sbueringer
changed the title
Default add GoCollector and ProcessCollector metrics for controller-runtime metrics package