Skip to content

feat: refactoring thresholds and usage assessment #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

feat: refactoring thresholds and usage assessment #1649

merged 2 commits into from
Mar 20, 2025

Conversation

ricardomaraschini
Copy link
Contributor

this commit refactors the thresholds and usage assessment for the node utilization plugins. both high and low plugins are affected by this change.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from a7i and seanmalloy March 14, 2025 09:49
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ricardomaraschini. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ingvagabund
ingvagabund reviewed Mar 14, 2025
View reviewed changes
ingvagabund
ingvagabund reviewed Mar 14, 2025
View reviewed changes
ingvagabund
ingvagabund reviewed Mar 14, 2025
View reviewed changes
ingvagabund
ingvagabund reviewed Mar 14, 2025
View reviewed changes
ingvagabund
ingvagabund reviewed Mar 17, 2025
View reviewed changes
@ingvagabund
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2025
@ricardomaraschini ricardomaraschini force-pushed the normalizer branch 2 times, most recently from bcdeda5 to 99e88bd Compare March 17, 2025 14:27
@ricardomaraschini
Copy link
Contributor Author

I have the impression that this e2e passed just a few minutes back. Are we dealing with a flake ?

/test pull-descheduler-test-e2e-k8s-master-1-30

ingvagabund
ingvagabund reviewed Mar 17, 2025
View reviewed changes
ingvagabund
ingvagabund reviewed Mar 17, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2025
ingvagabund
ingvagabund reviewed Mar 18, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2025
@ricardomaraschini ricardomaraschini force-pushed the normalizer branch 2 times, most recently from dccbaf4 to 84417cd Compare March 19, 2025 16:34
@ricardomaraschini
feat: refactoring thresholds and usage assessment
87ba84b 
this commit refactors the thresholds and usage assessment for the node
utilization plugins. both high and low plugins are affected by this
change.
@ricardomaraschini ricardomaraschini force-pushed the normalizer branch 3 times, most recently from ac9c192 to 75a98fb Compare March 19, 2025 19:43
ingvagabund
ingvagabund reviewed Mar 19, 2025
View reviewed changes
@ricardomaraschini
chore: comment the code and simplify some things
54d0a22 
this commit comments the low and high utilization plugins. this also
simplifies a little bit where it was possible without affecting too
much.
@ingvagabund
Copy link
Contributor

/approve
/lgtm

@ricardomaraschini thank you very much

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 89535b9 into kubernetes-sigs:master Mar 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@a7i a7i Awaiting requested review from a7i

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@ingvagabund ingvagabund

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardomaraschini @k8s-ci-robot @ingvagabund