Skip to content

TestLowNodeUtilizationKubernetesMetrics: set the right -cpu value for the cpu stressor #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

TestLowNodeUtilizationKubernetesMetrics: set the right -cpu value for the cpu stressor #1661

merged 1 commit into from
Apr 7, 2025

Conversation

ingvagabund
Copy link
Contributor

narmidm/k8s-pod-cpu-stressor@696ac0d added validation for the cpu param. Also, it turns out the param was not set correctly previously.

@ingvagabund ingvagabund added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from a7i April 7, 2025 08:51
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from damemi April 7, 2025 08:51
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2025
@ingvagabund ingvagabund mentioned this pull request Apr 7, 2025
Merged
@k8s-ci-robot k8s-ci-robot merged commit 38b1f5c into kubernetes-sigs:master Apr 7, 2025
9 checks passed
@ingvagabund ingvagabund deleted the e2e-TestLowNodeUtilizationKubernetesMetrics-set-the-right-cpu branch April 7, 2025 09:56
@ingvagabund ingvagabund mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7i a7i Awaiting requested review from a7i

@damemi damemi Awaiting requested review from damemi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingvagabund @k8s-ci-robot