Improve percentage calculation in ResourceUsageToResourceThreshold func #1683
Conversation
googs1025
commented
May 7, 2025
googs1025
commented
- Implemented precise calculation of resource usage percentages, rounding to two decimal places.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
|
/assign @ingvagabund |
| @@ -594,11 +595,18 @@ func ResourceUsageToResourceThreshold( | |||
| percent = float64(used) / float64(capacity) * 100 | |||
| } | |||
|
|
|||
| result[rname] = api.Percentage(percent) | |||
| roundedPercent := roundFloat(percent, 2) | |||
There was a problem hiding this comment.
There's thresholdsToKeysAndValues function used for printing percentages to 2 decimals. Is there another place where printing/computing with rounded numbers is needed?
There was a problem hiding this comment.
thanks 😄
I am trying to understand the implementation of nodeutilization. I'm curious Why is float64 not always rounded to two decimal places when used, but only used when printing logs?
There was a problem hiding this comment.
Rounding leads to a loss of precision. The less rounding the better. Though, the losses are probably very small. Yet, why take chances.
There was a problem hiding this comment.
got this. I have no further questions about this explanation. 😄
/close
|
@googs1025: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
