refactor: separate eviction constraints to constraints.go #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
googs1025
force-pushed
the
constraints_refactor
branch
from
3bb2ec3 to
16a80b2
Compare
|
/assign @ingvagabund 😄 ptal |
googs1025
force-pushed
the
constraints_refactor
branch
from
16a80b2 to
a2f07a5
Compare
ingvagabund
requested changes
May 19, 2025
| if priorityThreshold != nil && (priorityThreshold.Value != nil || len(priorityThreshold.Name) > 0) { | ||
| thresholdPriority, err := utils.GetPriorityValueFromPriorityThreshold(context.TODO(), handle.ClientSet(), priorityThreshold) | ||
| if err != nil { | ||
| klog.Errorf("failed to get priority threshold: %v", err) |
There was a problem hiding this comment.
This needs to return the error so it can be properly handled.
| return nil | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
There was a problem hiding this comment.
This function will be a no-op and will be invoked every time a pod is checked for eviction. What about to
change the function signature to return []constraint and return nil instead?
| return nil | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
| return nil | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
| } | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
| if labelSelector != nil { | ||
| selector, err := metav1.LabelSelectorAsSelector(labelSelector) | ||
| if err != nil { | ||
| klog.Error(err, "could not get selector from label selector") |
| indexName := "metadata.ownerReferences" | ||
| indexer, err := getPodIndexerByOwnerRefs(indexName, handle) | ||
| if err != nil { | ||
| klog.Error(err, "could not get pod indexer by ownerRefs") |
| return nil | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
| return nil | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
| return nil | ||
| } | ||
| } | ||
| return func(pod *v1.Pod) error { return nil } |
Signed-off-by: googs1025 <[email protected]>
googs1025
force-pushed
the
constraints_refactor
branch
from
6e79122 to
b3aeca7
Compare
|
/approve Thank you |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constraints.gomore info base on: #1665 (review)