Skip to content

frontend: Map: Add HPA Source #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2025
Merged

frontend: Map: Add HPA Source #3382

merged 1 commit into from
May 29, 2025

Conversation

adwait-godbole
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2025
@k8s-ci-robot k8s-ci-robot requested review from illume and vyncent-t May 28, 2025 17:18
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 28, 2025
@adwait-godbole adwait-godbole force-pushed the feat/add-hpa-map-source branch 2 times, most recently from a2e4ea6 to f801805 Compare May 28, 2025 17:27
@adwait-godbole
frontend: Map: Add HPA Source
2a35da9 
Signed-off-by: Adwait Godbole <[email protected]>
@adwait-godbole adwait-godbole force-pushed the feat/add-hpa-map-source branch from f801805 to 2a35da9 Compare May 28, 2025 17:38
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 28, 2025
illume
illume approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, and should probably be in this release.

Adding @yolossn @sniok as reviewers.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@illume illume requested review from sniok and yolossn and removed request for vyncent-t May 29, 2025 08:20
sniok
sniok approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great addition, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adwait-godbole, illume, sniok, yolossn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yolossn yolossn merged commit d90fdd7 into kubernetes-sigs:main May 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

@sniok sniok sniok approved these changes

@yolossn yolossn yolossn approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adwait-godbole @k8s-ci-robot @illume @sniok @yolossn