constants: change the variable name #584
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
There was a problem hiding this comment.
There's a problem with our integration test for krew version:
krew/integration_test/version_test.go
Line 50 in f958833
I looked for usages of the constants in GH and could not find any (https://github.com/search?q=krew%2Fpkg%2Fconstants%2Fconstants+language%3AGo&type=Code&ref=advsearch&l=Go&l=), so I'd not worry too much about breaking the API.
So, looks good to me.
This change indicates the possibility of non-centralized plugin index. However, this breaks the API (e.g. exported pkg/constants), so I'm not sure we should do this. Signed-off-by: Ahmet Alp Balkan <[email protected]>
|
ah yeah that version.go field should not have been changed. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For some reason when we refactored the const name constants.IndexURI kubernetes-sigs#584 its test run has inexplicably succeeded https://github.com/kubernetes-sigs/krew/runs/559491631 despite some references in main code + tests not updated. (I appreciate if someone can take a look why that has happened.) Signed-off-by: Ahmet Alp Balkan <[email protected]>
For some reason when we refactored the const name constants.IndexURI #584 its test run has inexplicably succeeded https://github.com/kubernetes-sigs/krew/runs/559491631 despite some references in main code + tests not updated. (I appreciate if someone can take a look why that has happened.) Signed-off-by: Ahmet Alp Balkan <[email protected]>
This change indicates the possibility of non-centralized plugin index. However,
this breaks the API (e.g. exported pkg/constants), so I'm not sure we should do
this.
/assign @corneliusweig