Skip to content

feat: Add EnableHttpMetrics option to Kueue Configuration API #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add EnableHttpMetrics option to Kueue Configuration API #4843

wants to merge 1 commit into from

Conversation

highpon
Copy link
Member

@highpon highpon commented Mar 31, 2025 •
edited
Loading

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Add an option to allow metrics to be retrieved via HTTP.
We want to retrieve metrics without HTTPS or TLS authentication.
In a closed network, it may be better not to have them.

Which issue(s) this PR fixes:

Fixes #4841

Special notes for your reviewer:

Does this PR introduce a user-facing change?

A new field, enableHttpMetrics, has been added to the Kueue Configuration API to allow controller metrics to be retrieved via HTTP.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 31, 2025
@k8s-ci-robot k8s-ci-robot requested review from kannon92 and mimowo March 31, 2025 16:18
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: highpon
Once this PR has been reviewed and has the lgtm label, please assign mimowo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 31, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 31, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit efe0a86
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67eac6f758d97f000818410f

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

@highpon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-main efe0a86 link true /test pull-kueue-verify-main
pull-kueue-test-e2e-main-1-33 efe0a86 link true /test pull-kueue-test-e2e-main-1-33

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

mszadkow
mszadkow reviewed May 29, 2025
View reviewed changes
apis/config/v1beta1/configuration_types.go
Comment on lines +172 to +176

// EnableHTTPMetrics, if true the controller's metrics
// will be accessible via HTTP only.
// +optional
EnableHTTPMetrics bool `json:"enableHttpMetrics,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lacks the note about the security risk and clear statement that is not recommended approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszadkow mszadkow mszadkow left review comments

@kannon92 kannon92 Awaiting requested review from kannon92

@mimowo mimowo Awaiting requested review from mimowo

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable to get metrics via HTTP
3 participants
@highpon @k8s-ci-robot @mszadkow