KEP 1287: Instrumentation for in-place pod resize #5340
Conversation
natasha41575
commented
May 23, 2025
natasha41575
commented
- One-line PR description:
- Add section with details about the metrics we plan to instrument for IPPR
- Issue link: In-Place Update of Pod Resources #1287
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
k8s-ci-robot
added
the
size/M
| Labels: | ||
| - `resource_type` - what type of resource is being resized. Possible values: `cpu_limits`, `cpu_requests` `memory_limits`, or `memory_requests`. If more than one of these resource types is changing in the resize request, | ||
| we increment the counter multiple times, once for each. This means that a single pod update changing multiple | ||
| resource types will be considered multiple requests for this metric. |
There was a problem hiding this comment.
ig this is a little weird but I'm not sure if the alternatives are better. We also already have apiserver_request_total{resource=pods,subresource=resize} if we just want the raw total number of resize requests to the api server
| - `resource_type` - what type of resource is being resized. Possible values: `cpu_limits`, `cpu_requests` `memory_limits`, or `memory_requests`. If more than one of these resource types is changing in the resize request, | ||
| we increment the counter multiple times, once for each. This means that a single pod update changing multiple | ||
| resource types will be considered multiple requests for this metric. | ||
| - `operation_type` - whether the resize is an increase or a decrease. Possible values: `increase`, `decrease`, `add`, or `remove`. |
There was a problem hiding this comment.
I'm assuming requests / limits can be added to a container but I don't actually know if that's true?? (I know kubernetes/kubernetes#127143 is adding support to remove them)
|
|
||
| #### `kubelet_pod_resize_requests_total` | ||
|
|
||
| This metric tracks the total number of resize requests observed by the Kubelet, counted at the pod level. |
There was a problem hiding this comment.
cc @ndixita
I don't have all the context but we might want to revisit or reuse this metric in the context of pod-level resources when resize of pod-level resources is supported
|
/assign @tallclair |
