Skip to content

fix: resolve env_file variable interpolation issues by adding support… #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

fix: resolve env_file variable interpolation issues by adding support… #2011

merged 2 commits into from
May 14, 2025
+276 −20

Conversation

yuefanxiao
Copy link
Contributor

… for and default syntax

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2010

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from cdrage and TessaIO May 7, 2025 17:26
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2025
@yuefanxiao
Copy link
Contributor Author

/assign @cdrage

@yuefanxiao
Copy link
Contributor Author

/cc @cdrage

@yuefanxiao
Copy link
Contributor Author

Hi @cdrage , thanks for your time!
Could you please take a look at this PR when you have a moment? I’d appreciate any feedback.

cdrage
cdrage approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! I honestly see no problems with this and the code is wonderful.

Great job and LGTM! :) I'm going to approve and if all the tests pass, it'll merge.

@cdrage
Copy link
Member

cdrage commented May 14, 2025

/approve

@cdrage
Copy link
Member

cdrage commented May 14, 2025 •
edited
Loading

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, yuefanxiao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@cdrage
Copy link
Member

cdrage commented May 14, 2025

Looks like one small test is failing

@yuefanxiao
Copy link
Contributor Author

Looks like one small test is failing看起来一个小测试失败了

Apologies for the test failure - I should have caught this during implementation. I'll investigate the issue immediately and provide a fix as soon as possible. Thank you for flagging this, and I'll update you once resolved.

@cdrage
Copy link
Member

cdrage commented May 14, 2025

Woooo 🚀 awesome work!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 4f59fe8 into kubernetes:main May 14, 2025
10 checks passed
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage cdrage approved these changes

@TessaIO TessaIO Awaiting requested review from TessaIO

Assignees

@cdrage cdrage

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Fails to parse default value syntax (e.g., ${VAR:-default}) in .env File, resulting in invalid configmap
3 participants
@yuefanxiao @cdrage @k8s-ci-robot