Skip to content

descheduler: standarize all CI job timeouts #33907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

descheduler: standarize all CI job timeouts #33907

merged 1 commit into from
Dec 5, 2024

Conversation

seanmalloy
Copy link
Member

  • All e2e jobs now have a 40m timeout
  • All unit test jobs now have a 10m timeout
  • All build jobs how have a 10m timeout
  • All verify jobs now have a 15m timeout (increased from 10m)

@seanmalloy
descheduler: standarize all CI job timeouts
a849413 
* All e2e jobs now have a 40m timeout
* All unit test jobs now have a 10m timeout
* All build jobs how have a 10m timeout
* All verify jobs now have a 15m timeout (increased from 10m)
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 4, 2024
@seanmalloy
Copy link
Member Author

/assign @damemi @ingvagabund @a7i

@seanmalloy seanmalloy mentioned this pull request Dec 4, 2024
Merged
damemi
damemi reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2024
@seanmalloy
Copy link
Member Author

@ingvagabund and @a7i please review when you have some time.

@ingvagabund
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 114527d into kubernetes:master Dec 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@seanmalloy: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key descheduler-presubmits-master.yaml using file config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-master.yaml
  • key descheduler-presubmits-release-1.29.yaml using file config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-release-1.29.yaml
  • key descheduler-presubmits-release-1.30.yaml using file config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-release-1.30.yaml
  • key descheduler-presubmits-release-1.31.yaml using file config/jobs/kubernetes-sigs/descheduler/descheduler-presubmits-release-1.31.yaml

In response to this:

  • All e2e jobs now have a 40m timeout
  • All unit test jobs now have a 10m timeout
  • All build jobs how have a 10m timeout
  • All verify jobs now have a 15m timeout (increased from 10m)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@seanmalloy seanmalloy deleted the descheduler-standarize-timeouts branch December 5, 2024 17:11
@seanmalloy seanmalloy mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi left review comments

@rjsadow rjsadow Awaiting requested review from rjsadow

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@damemi damemi

@ingvagabund ingvagabund

@a7i a7i

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanmalloy @k8s-ci-robot @ingvagabund @damemi @a7i