-
Notifications
You must be signed in to change notification settings - Fork 6.7k
refactor: Update Dropdown items to be in sync with other drop-downs #8232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
""" WalkthroughThe changes simplify the structure and styling of the publish dropdown menu in the frontend. The JSX component for the dropdown removes unnecessary wrappers and hover styles, adjusts dropdown positioning and sizing, and streamlines conditional rendering for the shareable playground item. Corresponding CSS rules are simplified, removing hover effects and nested selectors. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request refactors the
PublishDropdown
component and related styles in the frontend codebase to simplify the implementation and improve maintainability. Key changes include removing redundant CSS styles, adjusting dropdown menu alignments, and streamlining the structure of dropdown items.Component Refactor:
src/frontend/src/components/core/flowToolbarComponent/components/deploy-dropdown.tsx
: Removed unused CSS constants (groupStyle
andexternalUrlStyle
) and simplified the structure of dropdown menu items by removing unnecessarydiv
wrappers and redundant class assignments. Adjusted alignment offsets and dropdown menu width for better responsiveness. [1] [2] [3] [4]Style Updates:
src/frontend/src/style/applies.css
: Updated thedeploy-dropdown-item
class to use more concise and consistent styling, removing unnecessary@apply
statements and simplifying padding and font size.UI Component Adjustment:
src/frontend/src/components/ui/dropdown-menu.tsx
: Modified theDropdownMenuItem
component to remove unnecessary padding (px-2
) for a cleaner layout.Previous Styles
Screen.Recording.2025-05-30.at.9.47.58.AM.mov
New Styles
Screen.Recording.2025-05-30.at.9.55.31.AM.mov
Summary by CodeRabbit
Summary by CodeRabbit
Style
New Features