Desktop: Fixes #12295: Fix some importing by replacing error generation with default values #12338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedr
added
bug
|
Thanks for implementing but could you please split it into two PR - one to fix the bug, one for the logging improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12295
Summary
In this PR I'm fixing two errors:
ink_biaswas set to a invalid valuepage_series_nodedidn't have aentity_guidThankfully these two cases were able to be fixed by using a default value for both cases.
Testing
I added an automated test with the faulty notes, the automated test is just making sure that both notes exist and were turned into HTML.
I would like to have added a smaller test file, but every time I tried modifying the the OneNote notebook the files were deleted in the web interface, but were always presented in the generated backup. What I end up doing was include the role section and just testing the relevant files.