You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the SA, we mostly use structs internal to the SA to represent the database's storage of various objects, and translate those objects into proto messages to return from RPCs. There are three exceptions:
This follows the system we've used for other types, where the SA has a
model type that is converted to a proto message for use outside the SA.
Part of #8112.
The last bit of this, FQDNSet, requires some more tweaks to the expiration-mailer unittest. Rather than make those tweaks I'm going to consider this blocked on the removal of expiration-mailer.
In the SA, we mostly use structs internal to the SA to represent the database's storage of various objects, and translate those objects into proto messages to return from RPCs. There are three exceptions:
boulder/sa/database.go
Lines 272 to 274 in bc39780
Certificate, CertificateStatus, and FQDNSet use types from the
core
package as models. We should switch these to SA-internal models.The text was updated successfully, but these errors were encountered: