fix(kad): Don't wait for behaviour after receiving AddProvider
#3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Answering these requests is encapsulated within the behaviour. The user does not have any control over this.
thomaseizinger
commented
Nov 22, 2022
…libp2p/rust-libp2p into 3048-no-waiting-user-after-add-provider
|
TODO: Check if this also happens for any other events. |
mxinden
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Good catch @thomaseizinger. Thanks for debugging and fixing. Thanks @shamil-gadelshin for reporting the issue.
Assuming, that you are not implying that we should hold off with merging here. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we would erroneously always go into the
WaitingUser(now calledWaitingBehaviour) state after receiving a message on an inbound stream. However, theAddProvidermessage does not warrant a "response" from the behaviour. Thus, any incomingAddProvidermessage would result in a stale substream that would eventually be dropped as soon as more than 32 inbound streams have been opened.With this patch, we inline the message handling into the upper match block and perform the correct state transition upon each message. For
AddProvider, we go back intoWaitingMessagebecause the spec mandates that we need to be ready to receive more messages on an inbound stream.Fixes #3048.
Notes
Links to any relevant issues
Open Questions
Change checklist
I have added tests that prove my fix is effective or that my feature works