Skip to content

chore: add Desktop developer extension #7891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Wxh16144
Copy link
Contributor

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

Copy link

vercel bot commented May 19, 2025

@Wxh16144 is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 19, 2025
@lobehubbot
Copy link
Member

👍 @Wxh16144

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link
Contributor

gru-agent bot commented May 19, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 1cc687d ✅ Finished

Files

File Pull Request
src/store/middleware/createDevtools.ts ❌ Failure ([Tests Failed] The test file is correct and comprehensive, but the test runner fails due to a third-party environment issue unrelated to the test code.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@Wxh16144 Wxh16144 changed the title chore: add Desktop developer extension WIP chore: add Desktop developer extension May 19, 2025
params.delete('debug');
}
url.search = params.toString();
window.location.href = url.toString();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个只会在 开发者工具 窗口生效,得看看有没有其他更好的方式

@Wxh16144 Wxh16144 changed the title WIP chore: add Desktop developer extension chore: add Desktop developer extension May 28, 2025
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (585e386) to head (cb585e5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7891      +/-   ##
==========================================
+ Coverage   88.45%   95.67%   +7.21%     
==========================================
  Files         822       14     -808     
  Lines       60394     2519   -57875     
  Branches     4008      244    -3764     
==========================================
- Hits        53424     2410   -51014     
+ Misses       6970      109    -6861     
Flag Coverage Δ
app ?
server 95.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1,7 +1,7 @@
'use client';

import { ActionIcon, SideNav } from '@lobehub/ui';
import { Cog, DatabaseIcon } from 'lucide-react';
import { Cog, DatabaseIcon} from 'lucide-react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里revert下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像是我本地 git hook 每次都失败,我就绕过 hook 了.. 你们存在这个问题么?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里好像格式化有点问题

@@ -117,7 +118,7 @@ export class App {
app.exit(0);
}

this.initDevBranding();
SetupDev.init();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不用 await 么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image async 好像不是必须的,这个方法得在 app 准备好后进行安装,dev模式 await 感觉没啥必要,我测试过没有问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants