Skip to content

Docs: Update fastify.md with Global outputs #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2024
Merged

Docs: Update fastify.md with Global outputs #2176

merged 4 commits into from
Apr 15, 2024

Conversation

rumoursbehindme
Copy link
Contributor

@rumoursbehindme rumoursbehindme commented Mar 15, 2024

Description

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Mar 15, 2024

⚠️ No Changeset found

Latest commit: 485e13f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

linux-foundation-easycla bot commented Mar 15, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs addition! For the future we are recommending that devs use $global instead of out.global, but otherwise looks great!

Also, it may be worth linking to this page in case people are confused about serialization.

@rumoursbehindme rumoursbehindme changed the title Update fastify.md with Global outputs Docs: Update fastify.md with Global outputs Apr 8, 2024
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @rumoursbehindme!

@DylanPiercey
Copy link
Contributor

Thanks @rumoursbehindme

@DylanPiercey DylanPiercey merged commit 22ad069 into marko-js:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants