-
Notifications
You must be signed in to change notification settings - Fork 651
New core tags: <do>
, <log>
, <debug>
#2209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2209 +/- ##
==========================================
- Coverage 87.33% 87.28% -0.06%
==========================================
Files 326 329 +3
Lines 32151 32349 +198
Branches 1619 1642 +23
==========================================
+ Hits 28080 28236 +156
- Misses 4056 4098 +42
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Quick question: will Marko allow me to override these tags if I want to? |
Probably not. I don't think we've 100% settled on the order that tags are discovered yet, but iirc this is what we are currently thinking:
|
Note @svallory these tags only apply to marko 6 fyi. I think we'll likely maintain a similar behavior where you can override built-in tags but I think the verdicts still out before we hit beta. |
Yeah, I knew that was Marko 6 only :) I've been following the PRs to get some inside knowledge. The reason I asked is because I think those tag names may be going a bit too much into user land. Or at least something belonging to a standard library that is opt-in. I can definitely see myself wanting to write a , or tag that uses a specific library under the hood |
<do>
: Run code in the render phase<log>
: Log to the console<debug>
: Make a debug statement