Skip to content

Misc Improcements #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

Tags api

  • Remove unnecessary trailing params for compiled const/let.
  • Avoid using pushContainer and unshiftContainer apis which were causing unnecessary (re)traversal.
  • Ensure toReadable api returns a ReadableStream that is text encoded to work better with other whatwg apis.
  • ExposeMarko.RenderedTemplate and Marko.MountedTempalte types.

Class API

  • Expose toReadable api on render result which returns a text encoded whatwg ReadableStream.
  • ExposeMarko.RenderedTemplate and Marko.MountedTempalte types.

Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 8853a96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@marko/runtime-tags Patch
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey force-pushed the optimize-unecessary-ident-values-and-closures branch from 958253f to 8853a96 Compare March 31, 2025 16:52
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 79.41176% with 21 lines in your changes missing coverage. Please review.

Project coverage is 87.37%. Comparing base (fecb84e) to head (8853a96).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ages/runtime-class/src/runtime/html/AsyncStream.js 17.64% 14 Missing ⚠️
packages/runtime-tags/src/html/template.ts 77.77% 2 Missing ⚠️
...ckages/runtime-tags/src/translator/util/signals.ts 95.83% 2 Missing ⚠️
...s/runtime-tags/src/translator/core/html-comment.ts 0.00% 1 Missing ⚠️
...es/runtime-tags/src/translator/core/html-script.ts 0.00% 1 Missing ⚠️
...ges/runtime-tags/src/translator/core/html-style.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2604      +/-   ##
==========================================
- Coverage   87.40%   87.37%   -0.03%     
==========================================
  Files         356      356              
  Lines       41840    41849       +9     
  Branches     2900     2905       +5     
==========================================
- Hits        36570    36567       -3     
- Misses       5243     5255      +12     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey merged commit 70cb96e into main Mar 31, 2025
8 of 10 checks passed
@DylanPiercey DylanPiercey deleted the optimize-unecessary-ident-values-and-closures branch March 31, 2025 17:01
This was referenced Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant