Skip to content

[Tags API] Delimited attr csr optimize #2650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: f27dc6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 82.55814% with 120 lines in your changes missing coverage. Please review.

Project coverage is 87.35%. Comparing base (e1ba856) to head (f27dc6a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ime-tags/src/translator/visitors/tag/native-tag.ts 81.94% 102 Missing ⚠️
packages/runtime-tags/src/dom/dom.ts 50.00% 13 Missing ⚠️
packages/runtime-tags/src/common/helpers.ts 81.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
- Coverage   87.40%   87.35%   -0.06%     
==========================================
  Files         360      361       +1     
  Lines       43468    43764     +296     
  Branches     3183     3214      +31     
==========================================
+ Hits        37995    38228     +233     
- Misses       5445     5512      +67     
+ Partials       28       24       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey force-pushed the delimited-attr-csr-optimize branch from 7b1d0c5 to 63fda9c Compare April 16, 2025 03:51
@DylanPiercey DylanPiercey merged commit eda81ee into main Apr 16, 2025
8 of 10 checks passed
@DylanPiercey DylanPiercey deleted the delimited-attr-csr-optimize branch April 16, 2025 15:55
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant