Skip to content

[Tags API] fix: issues with class/style #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

[Tags API] fix: issues with class/style #2660

merged 2 commits into from
Apr 17, 2025

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Fixes an issue where class/style with both dynamic and static properties was not correctly outputting the static properties in csr.
  • After some discussion we have decided to remove the automatic px appending to numeric style property values.

Copy link

changeset-bot bot commented Apr 17, 2025

🦋 Changeset detected

Latest commit: a6501e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit bf6a0a2 into main Apr 17, 2025
6 checks passed
@DylanPiercey DylanPiercey deleted the wip branch April 17, 2025 17:40
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (21049fa) to head (a6501e8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2660      +/-   ##
==========================================
- Coverage   87.33%   87.33%   -0.01%     
==========================================
  Files         361      360       -1     
  Lines       43774    43696      -78     
  Branches     3220     3213       -7     
==========================================
- Hits        38230    38161      -69     
+ Misses       5519     5510       -9     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant