Skip to content

[Tags API] fix: add debug comments to serialize reasons #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: 4178722

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 91.48936% with 16 lines in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (d4969a2) to head (4178722).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/resume.ts 90.76% 4 Missing and 2 partials ⚠️
...ntime-tags/src/translator/visitors/program/html.ts 82.35% 6 Missing ⚠️
...kages/runtime-tags/src/translator/util/optional.ts 90.47% 2 Missing ⚠️
packages/runtime-tags/src/dom/control-flow.ts 75.00% 1 Missing ⚠️
...s/runtime-tags/src/translator/util/with-comment.ts 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
+ Coverage   87.32%   87.33%   +0.01%     
==========================================
  Files         360      361       +1     
  Lines       43794    43895     +101     
  Branches     3206     3216      +10     
==========================================
+ Hits        38242    38335      +93     
- Misses       5524     5533       +9     
+ Partials       28       27       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey merged commit b56bb18 into main Apr 18, 2025
8 of 9 checks passed
@DylanPiercey DylanPiercey deleted the wip branch April 18, 2025 15:52
@github-actions github-actions bot mentioned this pull request Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant