Skip to content

[Tags API] fix: sort signals by downstream value/intersections #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: 5f570fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey force-pushed the fix-signal-sorting branch 2 times, most recently from c50d759 to 3a3a8aa Compare April 23, 2025 22:22
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 96.62921% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (06c2fe4) to head (5f570fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/runtime-tags/src/translator/util/references.ts 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2670      +/-   ##
==========================================
- Coverage   87.59%   87.58%   -0.02%     
==========================================
  Files         361      361              
  Lines       43881    43868      -13     
  Branches     3262     3259       -3     
==========================================
- Hits        38436    38420      -16     
- Misses       5416     5419       +3     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey merged commit 42fff26 into main Apr 23, 2025
10 checks passed
@DylanPiercey DylanPiercey deleted the fix-signal-sorting branch April 23, 2025 23:14
@github-actions github-actions bot mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant