Skip to content

[Tags API] fix: for tag param closure in attr tags #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 28, 2025

🦋 Changeset detected

Latest commit: 7b01bdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 95.69378% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (ddf2b54) to head (7b01bdc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/runtime-tags/src/translator/util/references.ts 83.01% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2680      +/-   ##
==========================================
+ Coverage   87.63%   87.91%   +0.28%     
==========================================
  Files         361      361              
  Lines       43688    43815     +127     
  Branches     3250     3277      +27     
==========================================
+ Hits        38284    38518     +234     
+ Misses       5378     5271     -107     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey force-pushed the for-param-attr-tag-closure branch from 6260e6b to e3b1824 Compare April 28, 2025 17:55
@DylanPiercey DylanPiercey force-pushed the for-param-attr-tag-closure branch from e3b1824 to 7b01bdc Compare April 28, 2025 18:33
@DylanPiercey DylanPiercey merged commit 692c9a2 into main Apr 28, 2025
11 checks passed
@DylanPiercey DylanPiercey deleted the for-param-attr-tag-closure branch April 28, 2025 18:39
@github-actions github-actions bot mentioned this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant