Skip to content

Error checks print error but don't stop #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
terrillmoore opened this issue Mar 20, 2022 · 0 comments
Closed

Error checks print error but don't stop #5

terrillmoore opened this issue Mar 20, 2022 · 0 comments
Assignees
@terrillmoore
Labels
bug Something isn't working

Comments

@terrillmoore
Copy link
Member

Errors that need to exit should call _fatal, not _error. Seems like a bad name, but patch for now.
@terrillmoore terrillmoore added the bug Something isn't working label Mar 20, 2022
@terrillmoore terrillmoore self-assigned this Mar 20, 2022
terrillmoore added a commit that referenced this issue Mar 20, 2022
@terrillmoore
Merge pull request #6 from mcci-catena/issue5
ff988e4 
Fix #5: use _fatal when we can't continue
@terrillmoore terrillmoore mentioned this issue Mar 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@terrillmoore