Skip to content

Fix all lint errors #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Fix all lint errors #2627

merged 4 commits into from
May 5, 2025

Conversation

Dev-Khant
Copy link
Member

Description

Fix all lint errors

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

@johnwlockwood
Copy link
Contributor

nice, ruff check . passes with this.

@Dev-Khant
Copy link
Member Author

Hey @johnwlockwood Do you want me to merge this or your PR? If yours then can you please sign the CLAassistant?

@johnwlockwood
Copy link
Contributor

johnwlockwood commented May 5, 2025

@Dev-Khant if this fixes all the same issues, I'm fine with you choosing this one. I'd just like to be able to commit on branches I actually want to work on. This one also has additional changes, such as the ones to ci.yml that mine doesn't deal with.

@Dev-Khant Dev-Khant merged commit ec1d7a4 into main May 5, 2025
5 of 8 checks passed
@Dev-Khant
Copy link
Member Author

Hey @johnwlockwood Sure thanks, I have merged this one.

@Dev-Khant Dev-Khant deleted the user/dev/linting branch May 19, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants